Move systemd config to a templating approach. #19
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @MichelDiz)
a discussion (no related file):
Nothing blocking, but just seems overly complex than to just cat a HERE doc and output to the desired service. Here we have to do eval on static file fetched from github.
getdgraph.sh, line 31 at r1 (raw file):
sudo_cmd="" argVersion= myShell=$(which bash)
As mentioneed, using which in current $USER context, and not dgraph user's context could come back to cause a problem later.
getdgraph.sh, line 250 at r1 (raw file):
requires=$2 requiredBy=$3 command=$4
command is a reserved word in bash, but likely not cause a problem in this context.
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @darkn3rd and @MichelDiz)
a discussion (no related file):
Previously, darkn3rd (Joaquin Menchaca) wrote…
Nothing blocking, but just seems overly complex than to just cat a HERE doc and output to the desired service. Here we have to do eval on static file fetched from github.
Done.
This change is